Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
If this is intended behavior, then it needs to be documented better, somewhere besides here.
Like in the README.md and/or in here
It may be intended behavior, but unless Magisk warns that this is going to happen, then it is very counter-intuitive for the user. The user doesn't understand why they get a
I spent the whole day assuming it was my ROM that had failed to set up its
And simply running
If the design of Magisk Hide is inherently incompatible with rooted debug bridge, that's fine, but users should at least be warned of this incompatibility, preventing it from appearing as unexpected and confusing behavior.
EDIT: And the documentation should also note that (at least on Android 9) disabling Hide to get a plain umasked rooted system, doesn't seem to take full effect until after a reboot. That was the only way I could get rooted adb working, was to reboot the phone after disabling Hide.
If turning Hide off is supposed to work without a reboot, then I can file a separate bug report for that. But if it's intended behavior, then once again that should be made more obvious with some sort of documentation somewhere.
EDIT 2: I'm making this it's own issue since I'm not sure it will get noticed here. I don't think that's really redundant/a duplicate issue if it's phrased as a documentation bug rather than a functionality bug.