Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainer request #40

Closed
NewAlexandria opened this issue Mar 16, 2019 · 10 comments
Closed

Maintainer request #40

NewAlexandria opened this issue Mar 16, 2019 · 10 comments

Comments

@NewAlexandria
Copy link
Contributor

I'd like to see this in the AwesomeList. I'd like to be a mainter for such editorial purposes. Glad to help with other things. Thank you

@lvm
Copy link
Collaborator

lvm commented Mar 25, 2019

Hi there,
some time ago i created a PR there, but the amount of changes required plus the fact that this list should be treated as an extension of this person project, made me regret that decision.
personally, i'm not interested any longer on being listed there. not sure how the rest feels about this.

for the record, here's the pull request
sindresorhus/awesome#1049

@lvm lvm added the wontfix label Mar 25, 2019
@NewAlexandria
Copy link
Contributor Author

Style consistency is a common request for any collaborative codebase or project, so hopefully you can be willing to let someone else maintain that, who like to do such things.

@lvm
Copy link
Collaborator

lvm commented Mar 25, 2019

Sure thing, but one of the points was to remove/alter the "tags" in the list (such as GNU/Linux, FOSS, etc.) and i'm not interested in doing so. 🤷‍♂️

@shawnlawson
Copy link

What is the benefit to not being listed on sindresorhus/awesome? Creative coding is listed there. Not that live-coding is in direct competition with CC, but would be helpful to be acknowledged there, yes?

@NewAlexandria
Copy link
Contributor Author

@lvm I tried the look of putting tags on their own line. Thoughts?

https://github.com/NewAlexandria/awesome-livecoding

I realize it's a different look, but I — your friendly internet strange, it seems - votes that this is at least more readable than the existing style.

I also took a stab at a number of other linting, since I was sitting around fiddling on it while waiting on other code.

@NewAlexandria
Copy link
Contributor Author

hopeful and polite bump

@lvm
Copy link
Collaborator

lvm commented Mar 28, 2019

Hi @NewAlexandria,
to be sincere, i couldn't care less about the awesome-list but since you made all these changes (and am grateful for this), won't be completely stubborn and merge these changes.
but there are a couple of observations i'd like to make about your changes (mostly cosmetics and nothing really that serious):

[project](url) - Description {double space, line break} 
`list` `of` `tags`

is it because it throws an error/warning using that lovely awesome-lint?

and once again, thanks for your work

@lvm lvm removed the wontfix label Mar 28, 2019
@NewAlexandria
Copy link
Contributor Author

commented added to the PR

@NewAlexandria
Copy link
Contributor Author

Thanks for the merge!

@lvm
Copy link
Collaborator

lvm commented Apr 6, 2019

Done! Thanks for your work @NewAlexandria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants