Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize.db impl.get approximate sizes #16

Closed
rockeet opened this issue Oct 21, 2022 · 0 comments
Closed

Optimize.db impl.get approximate sizes #16

rockeet opened this issue Oct 21, 2022 · 0 comments

Comments

@rockeet
Copy link
Collaborator

rockeet commented Oct 21, 2022

This was a PR to upstream facebook/rocksdb#10634

Copied from facebook/rocksdb#10634

This PR speed up GetApproximateSizes by ~15%, in flame graph, GetApproximateSizes time percent is reduced from 7.01% to 5.92%.

Flame graph before this PR:

image

Flame graph after this PR:

image

Relevant commits

b51b0bd
e63de81
719af44

@rockeet rockeet closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant