Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MergingIterator.inline.comparator #26

Closed
rockeet opened this issue Oct 21, 2022 · 0 comments
Closed

MergingIterator.inline.comparator #26

rockeet opened this issue Oct 21, 2022 · 0 comments

Comments

@rockeet
Copy link
Collaborator

rockeet commented Oct 21, 2022

This is a PR to upstream facebook/rocksdb#10151

Copied from facebook/rocksdb#10151

MergingIterator is a performance critical class, one of the CPU hotpots are InternalComparator & UserComparator which are both virtual functions.
Since rocksdb Comparator has Name, this PR inline bytewise comparators code by checking comparator Name.

This PR is based on PR facebook/rocksdb#9035

Relevant commits

9f20ffc merging_iterator.cc: fix FORCE_INLINE
02458c4 merging_iterator.cc: add override
6bb244c merging_iterator.cc: ignore forceinline fail
7314205 merging_iterator.cc: format code
b91733d MergingIterator inline bytewise comparator
@rockeet rockeet closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rockeet