Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong winding order on toposimplify #7

Closed
Fil opened this issue Jul 25, 2017 · 4 comments
Closed

Wrong winding order on toposimplify #7

Fil opened this issue Jul 25, 2017 · 4 comments
Assignees

Comments

@Fil
Copy link

Fil commented Jul 25, 2017

countries.topo.json, winding order OK (from a visual check)

toposimplify -s 0.00001 < countries.topo.json > simplified.topo.json

=> the simplified file has a certain number of countries (e.g. ZAR-South Africa) which span the globe.

@Fil
Copy link
Author

Fil commented Jul 26, 2017

It fails with world-atlas/50m.json too, and in the browser:
http://blockbuilder.org/Fil/51b8b3f4aeb56138c671d690ef967a27

with

<script src="https://unpkg.com/topojson-client@3"></script>
<script src="https://unpkg.com/topojson-simplify@3"></script>

@Fil
Copy link
Author

Fil commented Jul 26, 2017

Happy to report that it works well with topojson-client@2.1.0 and topojson-simplify@2.0.0
http://blockbuilder.org/Fil/070d8e9df7093121a5d2e9851e9b2e48
with

<script src="https://unpkg.com/topojson-client@2"></script>
<script src="https://unpkg.com/topojson-simplify@2"></script>

@mbostock mbostock self-assigned this Jul 31, 2017
@mbostock
Copy link
Member

This appears to be caused by a5b9e65. Revert to the earlier definition of topojson.sphericalTriangleArea fixes the problem. (However, I am doubtful that reverting this definition is the correct fix to this issue.)

@mbostock
Copy link
Member

Fixed in 3.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants