Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL functionality lost #337

Open
wesbos opened this issue Jan 30, 2023 · 1 comment
Open

URL functionality lost #337

wesbos opened this issue Jan 30, 2023 · 1 comment

Comments

@wesbos
Copy link
Contributor

wesbos commented Jan 30, 2023

On th version of the site before your updates, the URL would change as you type. /for/y for /for/y

The URLs still work, but the urls are not changing as you type: https://www.toptal.com/developers/keycode/y

@konstrybakov
Copy link
Contributor

Hey, @wesbos, thank you for bringing this up. This feature was disabled on purpose for several reasons:

  • This feature doesn’t work as expected with users who use different keyboard layouts. So, for example, with this feature, I could create a URL like /keycode/for/ū, then copy and share it with someone who doesn’t use a Latvian keyboard or layout. This will result in a blank page unless we hardcode this letter and its info as well. We created the ability to share permalinks to the items from the table - it’s extensive but doesn’t cover all available variants for all available keys and codes (and is already not 100% correct for everyone). The way it was originally implemented is also not ideal if you would for example type an ä character and then reload the page - all the info will be missing
  • Another reason is SEO. It’s important to have identical content for a single URL at all times. And with that feature, the result would vary from os to os unless we hardcode every possible keycode which is also not possible due to the way the keycode detection works (a lot of variance for the same keys and codes between different layouts).

With this said, we decided to let this feature go until further improvement is agreed upon. For now, we decided to let the only permalinks be the keys in the table.

We have an idea for generating permalinks in the spirit of whatsmybrowser snapshots, taking into account all the data from the current user including the layout, but this will require some significant changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants