Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & Config #32

Closed
jrean opened this issue Jun 27, 2015 · 4 comments
Closed

Update & Config #32

jrean opened this issue Jun 27, 2015 · 4 comments

Comments

@jrean
Copy link

jrean commented Jun 27, 2015

Hi,

Just want to let you know I made some composer update these past few days and visibly you updated your package (I checked the commits history).

My app is tied with ~0.2 and after the update it started to stop working...
Undefined index: database_path

I knew it has something to do with the config...
When running php artisan vendor:publish --provider="Torann\GeoIP\GeoIPServiceProvider" it said Publishing Complete! (I had already your config published).

I had to manually delete the config file then re-run php artisan vendor:publish --provider="Torann\GeoIP\GeoIPServiceProvider" to make it works.

Is that normal?

(Very cool the php artisan geoip:update)

@shabith
Copy link

shabith commented Jul 6, 2015

Yes I can confirm that same thing happened to me. I got the same error and republishing the config file fixed it.

@cringerjs
Copy link

This is normal for Laravel as the publish command will not overwrite unless you specify it to. Just run it with the force option and it should work correctly.

php artisan vendor:publish --provider="Torann\GeoIP\GeoIP\GeoIPServiceProvider" --force

We should definitely check to make sure the file was written, however, before displaying the complete message.

@Torann
Copy link
Owner

Torann commented Oct 1, 2016

Sorry, the new version is going to do a better job a anticipating new config values.

@Torann Torann closed this as completed Oct 1, 2016
@jrean
Copy link
Author

jrean commented Oct 1, 2016

Awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants