Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Optimizations #7

Closed
torch2424 opened this issue Jan 4, 2020 · 1 comment
Closed

More Optimizations #7

torch2424 opened this issue Jan 4, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@torch2424
Copy link
Owner

From @MaxGraey in the Assemblyscript slack:

btw about opts. You could significantly speedup interop here and similar places:
https://github.com/torch2424/as-bind/blob/master/lib/supported-ref-types.js#L128

just use wasmExports.__getFloat32Array(responseRef).slice() instead
Float32Array.from(wasmExports.__getArray(responseRef))
Sometimes you could even don’t use slice if that result will use immediately) Adding .slice() (cloning) just for safety

similar for FLOAT64ARRAY, UINT32ARRAY and etc

@torch2424 torch2424 self-assigned this Jan 4, 2020
@torch2424 torch2424 added the enhancement New feature or request label Jan 4, 2020
@torch2424
Copy link
Owner Author

Oh this is actually a duplicate of #2 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant