Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Link's Awakening Sword Crash #142

Closed
Tracked by #197
torch2424 opened this issue Sep 12, 2018 · 7 comments · Fixed by #201
Closed
Tracked by #197

Fix Link's Awakening Sword Crash #142

torch2424 opened this issue Sep 12, 2018 · 7 comments · Fixed by #201
Labels
bug Something isn't working Core/Wasm Issues concerning the core library of Wasmboy

Comments

@torch2424
Copy link
Owner

Reported by @kyr0

Ironically, Link's awakening is the game I test the most on WasmBoy, and it totally works from what I can tell. I've gotten up to the first dungeon before.

Just to prove I'm not crazy, here's me with the sword running just fine 😄

screen shot 2018-09-12 at 10 55 30 am

screen shot 2018-09-12 at 10 56 21 am

Any more info would be awesome @kyr0 ! 😄

@torch2424 torch2424 added bug Something isn't working Core/Wasm Issues concerning the core library of Wasmboy labels Sep 12, 2018
@binji
Copy link

binji commented Sep 12, 2018

Maybe the original (non-color) version has issues?

@torch2424
Copy link
Owner Author

I play that one all the time too 😞 But I'll try it out tonight!

@kyr0
Copy link

kyr0 commented Sep 13, 2018

Hi :)

You can find the ROM I use on emulator.games, it is
Emulator.Games / ROMs / Gameboy / Legend Of Zelda, The - Link's Awakening (V1.2)

And well, I'm sorry but when I get the sword the owl says hello and then...

bildschirmfoto 2018-09-13 um 02 53 39

Link decides to sleep again xD

Also the audio playback turns into white noise playback ;)

@torch2424
Copy link
Owner Author

Ahh Yes it is the non GBC one. That's odd that the GBC one works and the GB one does not. Thanks for raising the bug! Plan on working on accuracy in the coming weeks once I do some much needed maintenance on some other open source projects 😄

@binji
Copy link

binji commented Sep 13, 2018

I was curious, so I checked that rom's sha1sum and it's the same as the one that I have: 5ab63def958728933571c3b4f6af54db14f3f8b2

When I ran https://wasmboy.app with this rom I didn't get a crash when I grabbed the sword, so I'm wondering if you are doing something different to trigger it, perhaps.

@kyr0
Copy link

kyr0 commented Sep 13, 2018

Hmm, I was trying again and this time I wasn't pressing any key when the owl talks and just let her talk. When I wait and press no key, it doesn't crash. When I press a key, for example "z", it crashes.

@torch2424
Copy link
Owner Author

Oh Huh this is all super interesting, thanks for the investigation @binji ! 😄

This was referenced Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core/Wasm Issues concerning the core library of Wasmboy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants