Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump django-crispy-forms to 2.0 #38

Closed
2 tasks
jams2 opened this issue Mar 16, 2023 · 2 comments · Fixed by #61
Closed
2 tasks

Bump django-crispy-forms to 2.0 #38

jams2 opened this issue Mar 16, 2023 · 2 comments · Fixed by #61
Assignees
@girapa

Comments

@jams2
Copy link
Collaborator

jams2 commented Mar 16, 2023

Changelog: https://github.com/django-crispy-forms/django-crispy-forms/blob/main/CHANGELOG.md#20a1-2023-01-18. I don't think the template pack changes affect us, so just review the other items.

Review django-crispy-forms/django-crispy-forms#296 for background on removing the safe filter.

Suggest starting from Balazs's branch: #28

We'll need to push our minimum supported Django version to 3.2 the current LTS release.

  • pyproject.toml is updated
  • tests are passing
@jams2
Copy link
Collaborator Author

jams2 commented Apr 12, 2023

Suggest pausing progress on this until #41 is resolved.

@kbayliss
Copy link
Collaborator

With #41 now merged, work here can continue :)

@kbayliss kbayliss linked a pull request Jan 31, 2024 that will close this issue
Bump django-crispy-forms to 2.0 #61
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girapa girapa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump django-crispy-forms to 2.0 olivierphi/tbxforms
3 participants
@kbayliss @jams2 @girapa