Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation for adding reports to cover permission restrict… #9859

Closed
wants to merge 2 commits into from

Conversation

Nazi-pikachu
Copy link
Contributor

@Nazi-pikachu Nazi-pikachu commented Jan 8, 2023

…ions

Fixes #6014
Please check the following:

  • Do the tests still pass?1
  • Does the code comply with the style guide?
    • Run make lint from the Wagtail root.
  • For Python changes: Have you added tests to cover the new/fixed behaviour?
  • For front-end changes: Did you test on all of Wagtail’s supported environments?2
    • Please list the exact browser and operating system versions you tested:
    • Please list which assistive technologies 3 you tested:
  • For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.

Footnotes

  1. Development Testing

  2. Browser and device support

  3. Accessibility Target

@squash-labs
Copy link

squash-labs bot commented Jan 8, 2023

Manage this branch in Squash

Test this branch here: https://nazi-pikachuupdate-doc-extendi-9xks7.squash.io

Copy link
Collaborator

@gasman gasman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nazi-pikachu! Just a couple of small tweaks to make here.

docs/extending/adding_reports.md Outdated Show resolved Hide resolved
docs/extending/adding_reports.md Outdated Show resolved Hide resolved
@gasman
Copy link
Collaborator

gasman commented Jan 9, 2023

Merged in 959a802.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for adding reports should cover permission restrictions
2 participants