Remove build dependencies. Fixes #985 and #958 #1019
Conversation
This commit removes libsass and Pillow from the setup.py dependency list. This greatly improves install performance and also means that the basic Wagtail installation is pure-python (so no build tools need to be on the end users host machine). None of these dependencies are directly called from within Wagtail so the start project command continues to work correctly.
| Required | ||
| -------- | ||
|
|
||
| * Django>=1.7.0,<1.8 |
There was a problem hiding this comment.
There's a good chance that we will forget to update this list...
There was a problem hiding this comment.
That is a very good point.
What is the best way to mention the dependecies, without forgetting to update the list? Should I link to https://github.com/torchbox/wagtail/blob/master/setup.py#L30 ?
There was a problem hiding this comment.
When people are installing from git, they should run python setup.py install from the root of the repo which will also install all of Wagtails dependencies.
Something like this: https://docs.djangoproject.com/en/1.7/topics/install/#installing-an-official-release-manually
There was a problem hiding this comment.
Thanks, @kaedroho. Changed with a link to setup.py for the full list of dependencies + added the note on running `python setup.py install``
And separate dependencies into 'barebones' and 'admin ui'
|
Looks good to me! |
|
Thanks, @zerolab! |
This PR builds on top of #985. It adds a "Dependecies" section to the "Installation" page, making it explcit that django-libsass and Pillow must be added to requirements.