Clean up drone settings a bit more from #1021 #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,8 +126,8 @@ | |||
| } | |||
|
|
|||
| # Check if we're running in Drone | |||
There was a problem hiding this comment.
You can remove this comment now
There was a problem hiding this comment.
Doh... removed now.
kaedroho
added a commit
that referenced
this pull request
Feb 23, 2015
Clean up drone settings a bit more from #1021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea if I'm doing the right thing here, but let's see what happens when I submit...
f2f57fb doesn't do the job for me, because: 1) I need to be able to pass in
DATABASE_HOST/DATABASE_PORTvariables for #1020, and 2) it seems a bit ugly for tests/settings.py to be checking for Drone specifically - the Drone config should be passing in the settings it needs instead. Here's my attempt at an improved version.