Add --postgres and --elasticsearch arguments to runtests.py #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes running the tests against PostgreSQL a bit easier
kaedroho
force-pushed
the
runtests-args
branch
from
8d4ba5e
to
a58f582
Compare
kaedroho
force-pushed
the
runtests-args
branch
from
0e7279a
to
7bdb458
Compare
The Elasticsearch tests now depend on an environment variable being set so we can safely install elasticsearch-py without Wagtail automatically assuming Elasticsearch is installed and running the tests. This makes developer setup slightly easier, but also opens up the possibility for running some of the ES tests that don't depend on a running ES instance.
We now only skip tests that actually require a running Elasticsearch instance. This also greatly cleans up the elasticsearch test suite.
kaedroho
force-pushed
the
runtests-args
branch
from
7bdb458
to
3f18768
Compare
kaedroho
added a commit
that referenced
this pull request
Nov 30, 2015
Add --postgres and --elasticsearch arguments to runtests.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes testing a little easier.
For example, to run tests without scrapping the DB, you currently have to run:
This PR shortens this to:
Also, we no longer automatically run ES tests if elasticsearch-py is installed. Meaning that this library can now be installed by all developers and most ES tests can be run