Fix dirtyFormCheck alerts in Safari #2793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing, Safari returns `body` for `event.explicitOriginalTarget || document.activeElement`. Therefore, we need to store a reference to the last clicked `$ignoredButtons` to hide the confirm dialog from being displayed.
|
After tearing my hair out trying to test this, I think once the prompt appears and is dismissed once, it never appears again, even after a force refresh, unless you quit the browser or re-enter the URL manually. I'm now working on a new solution based on #2801 that doesn't rely on checking button clicks at all, and hopefully avoids browser-specific special cases. |
|
Closing in favour of #2811 - testing the buttons/links that initiated the beforeunload event seems to be inherently unreliable across browsers (and fails to consider keyboard events), and we should use an approach that doesn't depend on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing, Safari returns
bodyforevent.explicitOriginalTarget || document.activeElement. Therefore, we need to store a reference to the last clicked$ignoredButtonsto hide the confirm dialog from being displayed.