Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 3202 Updated dependencies on setup.py #3207

Closed
wants to merge 2 commits into from

Conversation

MattRijk
Copy link
Contributor

@MattRijk MattRijk commented Dec 7, 2016

#issue 3202

Problem:
Sphinx-spelling is throwing an error when installing from setup.py
Fix:
Add pyenchant==1.6.6 before sphinxcontrib-spelling>=2.3.0 in install_requires [from documentation_extras]
Run pyenhant before sphinxcontrib-spelling and before document requirement packages (in required installs). pyenhant must be set to 1.6.6 (pip on ubuntu wants to install 1.6.8. This throws and error with other packages install. Wont install [babel, imagesize, docutils, sphinxcontrib-spelling])
Then update sphinxcontrib-spelling version -> changing to 2.3.0 works (was 2.1.1).
Every thing should install and python runtests.py - all tests ran with no E.

Techincal details
Wagtail: 1.7
Python version: 2.7.6.
Django version: Django==1.10.4
Tested on Ubuntu 14.04.3 LTS, MacOS, Windows7

…h sphinxcontrib-spelling

Fixes sphinxcontrib-spelling is throwing an error when installing from setup.py
@gasman
Copy link
Collaborator

gasman commented Dec 7, 2016

Thanks @MattRijk!

Are you sure that pyenchant and sphinxcontrib-spelling need to go in install_requires, rather than documentation_extras? This is something we'd want to avoid if possible, since it means that anyone who just wants to install Wagtail as an end-user (and has no intention of working on the Wagtail documentation) will end up installing a bunch of packages they don't need. Not the end of the world, of course, but I'd be keen to look for a solution that doesn't require this.

@gasman gasman added this to the 1.9 milestone Dec 7, 2016
@MattRijk
Copy link
Contributor Author

MattRijk commented Dec 7, 2016

Having it in doc extras works too. As long as its before Sphinx and the right package versions it should work. I'll change and resubmit

Documentation dependencies

documentation_extras = [
'pyenchant==1.6.6',
'sphinxcontrib-spelling>=2.3.0',
'Sphinx>=1.3.1',
'sphinx-autobuild>=0.5.2',
'sphinx_rtd_theme>=0.1.8',

]

@gasman
Copy link
Collaborator

gasman commented Dec 7, 2016

Thanks again! I can confirm that the new ordering works well for me too.

Merged in d5ec4fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants