Added page copy action to admin

[kaedroho]

This builds on my previous PR (#379) and adds admin UI for page copy

[davecranwell]

I'm afraid I missed a subtlety here when you emailed around the spec: Wouldn't the user need to be able to choose where to copy the page(s) to? Having to make a copy then move it - two steps - is undesirable.

[kaedroho]

I think in most cases, users would just want to copy into the same section of their website. Maybe we could add an optional step after the "set title and slug" form to allow them to move the copied page into a different section of the site at the same time if they wanted to.

[davecranwell]

I think that would be nice yeah. In a way it's the terminology that necessitates choosing a destination: "Duplicate" tends to imply "into the same section" whereas "Copy" is tightly coupled with "Paste" which can usually occur anywhere, generally speaking. I think being able to "copy" without being able to choose your "paste" is pretty counter-intuitive, so even if it's not a common requirement to copy to another section, it should definitely be an option.

I'd suggest you try and reuse the page chooser modal, as we would when choosing a link during page editing, placed below the title/slug fields, like you said.

[sixpearls]

Could the page chooser modal default to the current location (location of the original page)? This assumes the chooser handles going up the tree well, which I haven't played with.

[davecranwell]

I'm sure it could. I haven't tried it myself, but it's just a case of telling it which url to open on launch.

[chrxr]

Hi @kaedroho, we want to review and merge this as it stands in 0.4. @davecranwell please create an enhancement ticket for 0.5.

Thanks.

[davecranwell]

Done #390

[gasman]

I think we need more consideration of how this works with limited-permission users before it's ready to be merged. Some gotchas that spring to mind (may not be an exhaustive list)...

• Users without 'publish' permission on the destination section should not be able to create pages that are immediately live on the site. (My gut feeling is that all copied pages should be left unpublished after a copy, regardless of the user's permission level.)
• The copy action should respect the destination section's subpage_types setting, and not allow pages to be copied if that page type is not on the list. (This is only an edge case at the moment, since the copy remains in the same section as the original, but will become more relevant when we allow other destination sections to be selected.)
• Ownership of the new page(s) should be assigned to the user doing the copying (otherwise users with only 'add' permission will end up creating pages that they can't edit).