Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS embedding mistake #21

Closed
sashka opened this issue Sep 30, 2009 · 1 comment
Closed

CSS embedding mistake #21

sashka opened this issue Sep 30, 2009 · 1 comment

Comments

@sashka
Copy link

sashka commented Sep 30, 2009

Since this commit http://github.com/facebook/tornado/commit/aa836cdf3952d52efc68201872b3a0053aca33ad
there is always mistaken css style constructions appears if I've defined css_files(), but haven't defined embedded_css():

<style type="text/css">
.......
</style>

That's because you're filling css_embed with inclusion path.

   if css_files:
        ...
        css_embed = ''.join('<link href="' + escape.xhtml_escape(p) + '" '
                            'type="text/css" rel="stylesheet"/>'
                            for p in paths)
        ...
    if css_embed:
        css_embed = '<style type="text/css">\n' + '\n'.join(css_embed) + \
            '\n</style>'

I think you'll find the same problem with embedded_javascript() and javascript_files()

@sashka
Copy link
Author

sashka commented Nov 30, 2009

Silently closed by original authors.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant