Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tornado 6.0.2 has breaking change for @web.asynchronous decorator #2641

Closed
DavidJVitale opened this issue Apr 3, 2019 · 1 comment
Closed

tornado 6.0.2 has breaking change for @web.asynchronous decorator #2641

DavidJVitale opened this issue Apr 3, 2019 · 1 comment

Comments

@DavidJVitale
Copy link

Looks like tornado == 6.0.2 has some breaking changes from 5.X.X when used with Jupyter Notebook's nbconvert package. See this related issue for more info: jupyter/nbconvert#978

If this is a conscious breaking change on a major version release, feel free to close this issue. Just looking for clarification, thanks!
@ploxiln
Copy link
Contributor

ploxiln commented Apr 3, 2019

Yes, removing web.asynchronous was intentional:

https://www.tornadoweb.org/en/branch5.1/web.html#tornado.web.asynchronous

Deprecated since version 5.1: This decorator is deprecated and will be removed in Tornado 6.0. Use coroutines instead.

@bdarnell bdarnell closed this as completed Apr 4, 2019
@DavidJVitale DavidJVitale mentioned this issue Apr 4, 2019
Closed
@honglei honglei mentioned this issue Jun 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bdarnell @ploxiln @DavidJVitale