fix: globals: Fetch descriptors early #358
Conversation
So that sbws detect early changes in the relay descriptors. Closes: #30733. Bugfix v0.2.0.
sbws/globals.py
Outdated
| # Tor doesn't need all descriptors to function. In particular... | ||
| # | ||
| # * Tor no longer downloads server descriptors by default, opting | ||
| # for microdescriptors instead. |
There was a problem hiding this comment.
This comment is wrong, because we set UseMicrodescriptors 0 above.
There was a problem hiding this comment.
I guess it makes sense to have it in the context of stem, not sbws.
Fixup removed the context.
| # | ||
| # * If you aren't actively using Tor as a client then Tor will | ||
| # eventually stop downloading descriptor information altogether | ||
| # to relieve load on the network. |
There was a problem hiding this comment.
This is a good reason for us to use FetchUselessDescriptors: we don't want Tor going idle.
Replaced with actual man comment in the option. Edit: typos |
when fetching new consensuses. Closes: #30733.
I opened https://trac.torproject.org/projects/tor/ticket/30908 for this issue |
Hmm, i'm not iterating new_relays_dict but relays. Are you sure about this?, do you have a log with python 3.8?.
That's a condition, not a loop.
It seems to me a different case |
You're right, I closed the ticket as "not a bug". |
|
Closing in favor of #362 |
So that sbws detect early changes in the relay descriptors.
Closes: #30733. Bugfix v0.2.0.