Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next #7

Merged
1 commit merged into from Mar 15, 2011
Merged

Next #7

1 commit merged into from Mar 15, 2011

Conversation

adamw
Copy link
Contributor

@adamw adamw commented Mar 11, 2011

Hello,
the commits makes the maven reports generate a TEST-Ruby.xml file, which is in JUnit format. We are feeding this to TeamCity (using maven-antrun-plugin which runs:

 <echo message="##teamcity[importData type='junit' path='${project.build.directory}/TEST-Ruby.xml']" />

before the tests start), so that our tests are counted and we can see which passed/failed. I think other tools may consume this format as well.

Adam

…h is in JUnit's results format and enables the test results to be parsed e.g. by TeamCity and other tools which are familiar with the syntax.
@bobmcwhirter
Copy link
Contributor

Hm, I had a SurefireProgressReporter in there for a while. Might should see if we can pull it back from history. Or might've not made the rspec2 jump.

I'll take a look at this Monday, probably.

@mkristian
Copy link
Member

since I am about to make a release I tried to look in what happens to the surefire-reporter: it is still in place for rspec1 but not for rspec2. right now I gave up to get this to work for rspec2 - it is not just a quick fix.

want I could do is to pull that request and change the directory to target/surefire-reports and revert it once surefire-reporter is working for rspce2. once jruby-1.6.0 is out I would like to make another release anyways.

@bobmcwhirter
Copy link
Contributor

Oh, hey, I haven't investigated deeply, yet, but jruby-maven-plugin with a ruby script in the pom.xml via a works fine on unix, but seems to completely lose all double-quotes on Windows, resulting in syntax errors.

ie:

<script> foo = "hello world!" </script>

On Windows, JRuby ends up seeing a script like:

foo = hello world!

missing the double-quotes. I've had to edit stuff to be

foo = %Q(hello world!)

Or just use single-quotes, if I don't need #{interpolation}.

Anyhow, this worked a while ago, not sure the change that regressed it.

-Bob

On Mar 12, 2011, at 5:28 AM, mkristian wrote:

since I am about to make a release I tried to look in what happens to the surefire-reporter: it is still in place for rspec1 but not for rspec2. right now I gave up to get this to work for rspec2 - it is not just a quick fix.

want I could do is to pull that request and change the directory to target/surefire-reports and revert it once surefire-reporter is working for rspce2. once jruby-1.6.0 is out I would like to make another release anyways.

https://github.com/mkristian/jruby-maven-plugins/pull/7#issuecomment-863342

@mkristian
Copy link
Member

that script problem is weird since the java-ant-task will get the same parameters/config for any OS and only under the hood the OS switch takes place.

anyways I needed to skip the patch of Adam - there were suddenly so many little things in the way to the release . . .

@adamw
Copy link
Contributor Author

adamw commented Mar 14, 2011

Ah right, the surefire reporter - forgot about it, sorry :). Just had in the back of my head that I should finally send my changes (which we are using for half a year now) and I forgot that I talked to you (Bob) about it then.

Still, maybe it would be better to have one file with the tests results (instead of one-per-file)? That would make my use case (importing into TC) possible.

@mkristian
Copy link
Member

OK merged it and added a config parameter since I believe the surefire reports shall be default (well still missing for rspec2 ;-)

thanx, Kristian

@headius headius added this to the pre-3.0.0 milestone Aug 9, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants