Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: non-generic dict being subscribed #1315

Merged
merged 1 commit into from Jan 11, 2023
Merged

fix: non-generic dict being subscribed #1315

merged 1 commit into from Jan 11, 2023

Conversation

zmievsa
Copy link
Contributor

@zmievsa zmievsa commented Jan 4, 2023 •
edited

Description

In my prior PR, I used a non-generic dict which made ci fail on python >3.9.

Motivation and Context

Fix a critical bug

How Has This Been Tested?

This does not need any testing

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@long2ice
Copy link
Member

Thanks!

@long2ice long2ice merged commit 978c2db into tortoise:develop Jan 11, 2023
waketzheng pushed a commit to waketzheng/tortoise-orm that referenced this pull request Jun 21, 2023
@zmievsa @waketzheng
fix: non-generic dict being subscribed (tortoise#1315)
6fc02a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zmievsa @long2ice