Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include toml.hpp in example is incorrect? #72

Closed
russkel opened this issue Jul 8, 2019 · 3 comments
Closed

include toml.hpp in example is incorrect? #72

russkel opened this issue Jul 8, 2019 · 3 comments

Comments

@russkel
Copy link

russkel commented Jul 8, 2019

Hi,

The example in the README currently shows:

#include <toml11/toml.hpp>
#include <iostream>

But that file doesn't exist with my CMake installed library. I have to use #include <toml.hpp>. Maybe the example[s] needs an update?

@ToruNiina
Copy link
Owner

Yes, you are right.

I thought it is helpful to explicitly write a repository name because cmake did not support install command when I wrote it. At that time, I supposed that this library would be installed as a git submodule or be cloned under the project directory.

But now I think it is nicer to have #include <toml.hpp> there since there are several way to install it and also the directory name could be changed.

@russkel
Copy link
Author

russkel commented Jul 9, 2019

Fair enough. Feel free to close this if it was personal choice. I thought it was an artefact of a previous toml11 era.

ToruNiina added a commit that referenced this issue Jul 9, 2019
@ToruNiina
Copy link
Owner

updated.

kenichiice added a commit to kenichiice/toml11 that referenced this issue Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants