Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Partial stack takes a long time to deploy #104

Open
gkpty opened this issue Aug 14, 2020 · 0 comments
Open

Bug: Partial stack takes a long time to deploy #104

gkpty opened this issue Aug 14, 2020 · 0 comments
Labels
bug Something isn't working
Projects
Torus Host

Comments

@gkpty
Copy link
Collaborator

gkpty commented Aug 14, 2020

the partial stack unnecessarily takes a long time to deploy. This is mostly because of the records. These records are unecessary when the stack also contains a CDN as they will be overwritten.

Add an additional parameter: fullStack in generateTemplate that contains the complete stack from params. in the deployFull template stack and fullStack will be the same.

only add records in the partialTemplate if config[dns] === 'aws' && !fullstack['cdn']
@gkpty gkpty added the bug Something isn't working label Aug 14, 2020
@gkpty gkpty added this to Current Sprint in Torus Host Aug 21, 2020
@gkpty gkpty moved this from Current Sprint to In progress in Torus Host Aug 23, 2020
@gkpty gkpty moved this from In progress to Review Q&A in Torus Host Aug 23, 2020
@gkpty gkpty mentioned this issue Sep 6, 2020
Merged
@lucaskardo lucaskardo moved this from Review Q&A to Done in Torus Host Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Torus Host
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gkpty