Skip to content

Commit

Permalink
userns: Fix posix_acl_file_xattr_userns gid conversion
Browse files Browse the repository at this point in the history
The code needs to be from_kgid(make_kgid(...)...) not
from_kuid(make_kgid(...)...). Doh!

Reported-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
  • Loading branch information
ebiederm committed Oct 12, 2012
1 parent 1bbb309 commit ea1fd77
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/xattr_acl.c
Expand Up @@ -45,7 +45,7 @@ static void posix_acl_fix_xattr_userns(
break; break;
case ACL_GROUP: case ACL_GROUP:
gid = make_kgid(from, le32_to_cpu(entry->e_id)); gid = make_kgid(from, le32_to_cpu(entry->e_id));
entry->e_id = cpu_to_le32(from_kuid(to, uid)); entry->e_id = cpu_to_le32(from_kgid(to, gid));
break; break;
default: default:
break; break;
Expand Down

0 comments on commit ea1fd77

Please sign in to comment.