feat(kernel): Add message IDs to make it easier to trace messages #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for merry-scone-cc7a60 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
hawkw
approved these changes
Jul 25, 2022
| .map_err(|_| RegistrationError::RegistryFull) | ||
| .map_err(|_| RegistrationError::RegistryFull)?; | ||
| info!(uuid = ?RD::UUID, service_id = self.counter, "Registered"); | ||
| self.counter = self.counter.wrapping_add(1); |
There was a problem hiding this comment.
wonder if we should maybe log something in the event that this wraps, just so that a reader of the logs will know that they may see the same IDs repeat
There was a problem hiding this comment.
Kicking this can down the road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a number of
u32ID fields to each message in order to make tracing interactions between services easier.u32might be too much (I suspect u16 is probably enough, at least for service/client IDs), but I think this is a fine place to start. Most of the metadata insertion is "hidden" from end-consumers, happening in the built-in client and service handles, which means it should be hard to get wrong or forget to do.