This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
[BuildTrigger] Branch/commit/tag history #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshi0383
commented
Dec 23, 2018
| @@ -3,4 +3,4 @@ github "ishkawa/APIKit" | |||
| github "ReactiveX/RxSwift" | |||
| github "onmyway133/DeepDiff" | |||
| github "realm/realm-cocoa" | |||
| github "raspu/Highlightr" | |||
| github "toshi0383/Highlightr" "master" | |||
toshi0383
commented
Dec 23, 2018
| if !Device.isPhoneX { | ||
| rootStackView.topAnchor.constraint(equalTo: view.topAnchor).isActive = true | ||
| } | ||
|
|
There was a problem hiding this comment.
Spent a day to find this old code.😅
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=========================================
- Coverage 4.78% 4.41% -0.37%
=========================================
Files 42 44 +2
Lines 1756 1903 +147
=========================================
Hits 84 84
- Misses 1672 1819 +147
Continue to review full report at Codecov.
|
toshi0383
commented
Dec 24, 2018
toshi0383
commented
Dec 24, 2018
toshi0383
commented
Dec 24, 2018
toshi0383
commented
Dec 24, 2018
|
Will do further refactoring in next PR. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch/commit/tag names are suggested based on history.
History is saved in realm database.
Future TODO
#54