-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple classes for no_toc_section_class
#70
Comments
Friendly ping @toshimaru :) I could replace those headers with a header > 5 but ideally this should be fixed. |
@XhmikosR Hi, I checked your site and I found you configured custom class for https://github.com/twbs/bootstrap/blob/9788baedeadddba9d0bcd4dbaea43d65ece9bcbd/_config.yml#L65 You have two options.
I think it's not a bug, so I close the issue, but if any further issue, please let me know. |
@toshimaru How come you think it's not a bug? I already add the |
I'd say I already gave options to fix a issue. I'm a not English speaker so if you can't understand the options I gave, could you explain why it doesn't make sense? I could explain the detail more. 👍 |
|
OK, maybe I misunderstood the docs. I will try something else and if it works then the docs need to be clarified. |
I got it, you'd like to configure multiple So, I'd like to propose another option:
For exmaple: <div class="bd-example"> Change it to: <div class="bd-example no_toc_section"> |
Yeah but that's the problem, we have 133 |
Hmm, I originally don't want to allow I change this issue title and re-open it. |
no_toc_section
still adds ToCno_toc_section_class
I'm not very familiar with Ruby, but it shouldn't have a noticeable performance penalty in theory. Let me know if you make a beta with this feature. Thanks! |
Yes, you’re probably right, I’m being too sensitive about the performance. I could implement this without the performance impact, am going to release it in the next version. :) |
@XhmikosR Allowing multiple ref. https://github.com/toshimaru/jekyll-toc#skip-toc-section |
For example
results in this being included in ToC
https://github.com/twbs/bootstrap/blob/9788baedeadddba9d0bcd4dbaea43d65ece9bcbd/site/_includes/callout.html#L1-L9
Demo: https://twbs-bootstrap4.netlify.com/docs/4.1/utilities/colors/
If I change the header to an h5, since we have max h4, then the header is not included in ToC.
/CC @toshimaru
The text was updated successfully, but these errors were encountered: