Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The solution for exercise three does not test a simple case #38

Closed
eg180 opened this issue Sep 14, 2022 · 2 comments
Closed

The solution for exercise three does not test a simple case #38

eg180 opened this issue Sep 14, 2022 · 2 comments

Comments

@eg180
Copy link

eg180 commented Sep 14, 2022

This seems so simple that maybe I'm overthinking it and wrong? Either way, I'm not sure why we don't test the case that it works with just the last name as well.

@mattpocock
Copy link
Collaborator

I'm confused by what you mean. It shouldn't work with just the last name: it needs the first name.

@eg180
Copy link
Author

eg180 commented Sep 15, 2022

Ahhh okay - I saw 'optional properties' (plural) and automatically assumed it meant both should be optional. Anyway - thanks for these exercises, Matt. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants