Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should it be possible to override framework.global from a controller? #404

Closed
originalfoo opened this issue May 16, 2016 · 2 comments
Closed

Comments

@originalfoo
Copy link

This looks dodgy:

https://github.com/totaljs/framework/blob/v2.0.0/index.js#L10215

It would allow any script to completely overwrite framework.global just by setting this.global on a controller. Is that intended functionality?

@petersirka
Copy link
Collaborator

It looks dodgy, but it works correctly. Second question: yes, but property transfers only reference to the F.global. But better solution will be to remove this property from the controller.

@petersirka
Copy link
Collaborator

@aubergine10 removed 👍
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants