Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document HTTPS support #113

Closed
markmetcalfe opened this issue Sep 11, 2020 · 7 comments
Closed

Document HTTPS support #113

markmetcalfe opened this issue Sep 11, 2020 · 7 comments
Labels
enhancement New feature or request Nginx README

Comments

@markmetcalfe
Copy link
Contributor

Having HTTPS support with our sites may be useful to have. It would give the advantage of letting us save common login password info, marginally increase page load speed, and would stop that warning message when installing/upgrading totara via the web UI.

To implement this we would need to add a server {} directive for the 443 port in the nginx server.conf, and would need to create a root certificate that supports all the totaraXX/totaraXX.debug hosts. Then the dev using docker-dev would need to manually add the root cert to their system's trusted certs.

@markmetcalfe markmetcalfe added enhancement New feature or request Nginx labels Sep 11, 2020
@derschatta
Copy link
Member

HTTPS support is already there :)

@derschatta
Copy link
Member

It's just not documented

@derschatta
Copy link
Member

hm doesn't seem to work anymore, need to check and fix it

@markmetcalfe
Copy link
Contributor Author

Yeah ideally this repo would include a pem/key so you can easily add it to your host system's trusted certs - I don't see the cert file currently.

@derschatta
Copy link
Member

started to improve this but it turns out to be a bit more complicated than I expected to set up a CA and have a certificate verified by it. Currently, the built-in https support works in all browser but Chrome. Just access the site via https://totara73 for example. You get a warning as the certificate is self-signed but in all browser except Chrome you can accept and continue.

@elkbullwinkle
Copy link

You can add your root cert into the keychain on the mac and make it trusted, it will make all the certs signed by that one trusted on your computer.

@markmetcalfe
Copy link
Contributor Author

markmetcalfe commented Sep 30, 2020

So the solution to this then is just adding instructions to the README on how to add the totara cert as a trusted CA on each platform

@markmetcalfe markmetcalfe changed the title Add HTTPS support Document HTTPS support Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Nginx README
Projects
None yet
Development

No branches or pull requests

3 participants