[Fix] Session Block #161
Closed
[Fix] Session Block #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey everyone, what's the status on getting this one in before NYC 🇺🇸 or the London 🇬🇧 droidcon 🙌 |
|
😢 |
|
Hey @hopeman15, we've had a lot going on. Thank you for the PR, unfortunately our goal was to put the sessions that begin at the same time into a single block. The implementation on Android isn't great as it indeed looks broken. Instead it should look like a single card with the content divided by separators. |
|
@TadeasKriz I see 🤔 new PR in coming 🎁 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the padding issues on the session blocks. When you have a time slot with multiple sessions they all ran together. This fixes #160