Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The compressor code should have a credit for the original author #2

Closed
arnabc opened this issue May 27, 2016 · 2 comments
Closed

The compressor code should have a credit for the original author #2

arnabc opened this issue May 27, 2016 · 2 comments

Comments

@arnabc
Copy link

arnabc commented May 27, 2016

The SiliCompressor.java is identical to the code provided by Ambalika Saha (http://voidcanvas.com/whatsapp-like-image-compression-in-android/) in her blog, at least you should give her due credit either in Readme or in the Source Code of that file.
@Tourenathan-G5organisation
Copy link
Owner

Yes, you are right. I will do so.

@Tourenathan-G5organisation
Copy link
Owner

@arnabc thanks for your point. I have fix the issue on the readme. You can check.

fishkingsin pushed a commit to nixplay/SiliCompressor that referenced this issue Jan 22, 2018
@raymondctc
Merge pull request Tourenathan-G5organisation#2 from 9gag-open-source…
bee0cbe 
…/feature/1-flexibleVidCompression

Tourenathan-G5organisation#1 - Support more flexible video compression config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arnabc @Tourenathan-G5organisation