-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock dont get released after script is done #9
Comments
I encounter this problem in some projects, too. It happens when a page of type shortcut is requested with a speaking URL. In this case it takes TTL for TYPO3 to create a response because of the blocked locking. Adding the destructor solves the problem. It would be great if you could add that and make a new tag. Until this fix is applied the attached patch can be used for version 3.0.1 It can be applied easily for example via composer. |
We have run into terrible issues due to the missing destructor/release when the rendering is stopped due to e.g.: TSFE->pageNotFoundAndExit() |
Same here... It's also problematic while debugging. When "stopping" (terminating) the request while a debug-session, the pagegeneration-lock stays and the next request have to wait the whole rest of the ttl. |
Same here, we've implemented the patch and it works so far. Thank you! |
There should be a destructor in RedisLockStrategy.php to release the lock otherwise it takes the full ttl time until lock is released (maybe not in every case, i encounter this issue with redirects).
The text was updated successfully, but these errors were encountered: