Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Servers not notified of canceled requests #29

Closed
olix0r opened this issue May 29, 2018 · 0 comments
Closed

Servers not notified of canceled requests #29

olix0r opened this issue May 29, 2018 · 0 comments
Assignees

Comments

@olix0r
Copy link
Contributor

olix0r commented May 29, 2018

When a tower-h2 server receives a request that is canceled, the server needs to be able to stop doing work on behalf of the request. I believe that this has two implications:

  1. When the response future has not yet been satisfied, the server should drop the response future.
  2. When the response has been satisfied and its body is streaming, the server should drop both the response parts and body.

With this change middlewares like tower-buffer can ensure proper cancellation semantics without having to be protocol-aware.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants