master branch fails with tox master

[gaborbernat]

[7931] /home/vsts/work/1/s/upstream/tox-travis$ /home/vsts/work/1/s/upstream/tox-travis/.tox/py37/bin/py.test
============================= test session starts ==============================
platform linux -- Python 3.7.2, pytest-4.5.0, py-1.8.0, pluggy-0.11.0
cachedir: .tox/py37/.pytest_cache
rootdir: /home/vsts/work/1/s/upstream/tox-travis
plugins: mock-1.10.4
collected 57 items

tests/test_after.py .................                                    [ 29%]
tests/test_envlist.py .FFFFFFFFFFFFFFFFFFFFFFFFFFFF.....                 [ 89%]
tests/test_hacks.py .                                                    [ 91%]
tests/test_hooks.py ..                                                   [ 94%]
tests/test_utils.py ...                                                  [100%]

=================================== FAILURES ===================================
____________________ TestToxEnv.test_travis_config_filename ____________________

self = <test_envlist.TestToxEnv object at 0x7f9bb2f7ed30>
tmpdir = local('/tmp/pytest-of-vsts/pytest-1/test_travis_config_filename0')
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f9bb2f7ee80>

    def test_travis_config_filename(self, tmpdir, monkeypatch):
        """Give the correct env for manual filename."""
        with self.configure(tmpdir, monkeypatch, tox_ini, 'CPython', 3, 6,
                            ini_filename='spam.ini'):
>           assert self.tox_envs(ini_filename='spam.ini') == ['py36']
E           AssertionError: assert ['py26', 'py2...ypy3', 'docs'] == ['py36']
E             At index 0 diff: 'py26' != 'py36'
E             Left contains 5 more items, first extra item: 'py27'
E             Use -v to get the full diff

[rpkilby]

This is related to the change in behavior to the -l argument. See tox-dev/tox#1284 (comment).

[ryanhiebert]

Thanks for looking into it, @rpkilby. Do you think that using envlist_default is the way to resolve this?

[rpkilby]

At the very least, it's a good enough short term solution. envlist_default is only used in two places - the show_env and show_config commands. And given that envlist modification only occurs in CI, this should be relatively safe.

[rpkilby]

btw, the envlist_default workaround hasn't caused me any issues. rpkilby/tox-factor#6

[ryanhiebert]

Thanks for confirming that.