Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toxenv match run environments #44

Closed
ryanhiebert opened this issue Dec 21, 2016 · 0 comments · Fixed by #78
Closed

Make toxenv match run environments #44

ryanhiebert opened this issue Dec 21, 2016 · 0 comments · Fixed by #78

Comments

@ryanhiebert
Copy link
Collaborator

ryanhiebert commented Dec 21, 2016

Currently the toxenv after all option looks at the TOXENV environment variable. This is mostly useful, because it's quite common to set that environment variable to control tox, and tox-travis uses it under the hood.

However, it fails in a couple of cases:

  1. No TOXENV is set. This is mostly a non-concern for us, because we always set it.
  2. -e env is given to tox. This is the more annoying part, because it might be used. It's a reasonable limitation for a first version, but there's probably going to be someone somewhere that is surprised by this, and I won't blame them.

What I'd like to do, if possible, is inspect Tox's run somehow, so that I know which envs were actually run, and match against those instead of relying on the environment variable.

@ryanhiebert ryanhiebert changed the title Let toxenv match actually run environments Let toxenv match run environments Dec 21, 2016
@ryanhiebert ryanhiebert changed the title Let toxenv match run environments Make toxenv match run environments Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant