New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --pre pip option by default #193

Closed
pytoxbot opened this Issue Sep 17, 2016 · 5 comments

Comments

Projects
None yet
1 participant
@pytoxbot

pytoxbot commented Sep 17, 2016

This can break some builds

I looked at the Changelog for when this change was introduced, and apparently pip would refuse to install the exactly specified prerelease dependencies unless the --pre flag was supplied

#!text

Also the default [py25] environment modifies the
 default installer_command (new config option) to use pip without the "--pre" 
 which was introduced with pip-1.4 and is required if you want to install non-stable releases.
 (tox defaults to install with "--pre" otherwise).

This is understandable, but apparently it's not the case anymore, since if you run pip install coverage==4.0a1 it will install the package without making a fuss

I don't know when pip changed its behavior, but it'd be nice to take it into account now

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

tox-1.9 does not use --pre by default anymore.

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @cjw296

I'll second the voices in Ned's posting: please remove --pre, it creates unpleasant breakage...

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @dstufft

Sort of? pip install foobar>=1.4.0.dev1 would enable --pre only for foobar, not for the dependency foobar has on other-thing>=1.0 (unless of course the dependency was other-thing>=1.0.dev1.

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

if i do pip install >=1.4.0.dev1 does it effectively mean pip install --pre >=1.4.0.dev1?

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @dstufft

FWIW I don't think pip ever mandated that you have --pre in order to install a pre-release, you could specify a version specifier that includes a pre-release and that would trigger it as well (see: pypa/pip#834).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment