New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py example will hang forever #233

Closed
pytoxbot opened this Issue Sep 17, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@pytoxbot

pytoxbot commented Sep 17, 2016

In the setuptools integration example in the documentation

The script will hang forever if there are no arguments passed to tox.

This is because the argument to shlex.split() is None so it waits to read from stdin.

I suggest to change the example to something like the below.

#!python

    def run_tests(self):
        import tox
        import shlex
        args = self.tox_args
        if args:
            args = shlex.split(self.tox_args)
        errno = tox.cmdline(args=args)
        sys.exit(errno)
@pytoxbot

This comment has been minimized.

Show comment
Hide comment
@pytoxbot

pytoxbot Sep 17, 2016

Original comment by @hpk42

fix issue233: avoid hanging with tox-setuptools integration example. Thanks simonb.

→ <<cset 7fb0ae11640d>>

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

fix issue233: avoid hanging with tox-setuptools integration example. Thanks simonb.

→ <<cset 7fb0ae11640d>>

@pytoxbot pytoxbot closed this Sep 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment