Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type-checking #3260

Merged
merged 1 commit into from Apr 2, 2024
Merged

Fix type-checking #3260

merged 1 commit into from Apr 2, 2024

Conversation

stefanor
Copy link
Contributor

@stefanor stefanor commented Apr 1, 2024

Update test typing for build 1.2.0 which has an explicit Distribution type.

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

stefanor
stefanor commented Apr 1, 2024
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@stefanor
Fix type-checking
8c77423 
Update test typing for build 1.2.0 which has an explicit Distribution type.
@gaborbernat gaborbernat merged commit a22fe8f into tox-dev:main Apr 2, 2024
25 checks passed
@stefanor stefanor deleted the fix-typing branch April 2, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layday layday layday left review comments

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefanor @gaborbernat @layday