Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With setuptools dropping python2.6, do we finally have enough precedent to drop it ourselves? #679

Closed
asottile opened this issue Nov 21, 2017 · 13 comments

Comments

@asottile
Copy link
Member

@asottile asottile commented Nov 21, 2017

http://setuptools.readthedocs.io/en/latest/history.html#v37-0-0

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Nov 21, 2017

I'm 👍 on the idea. We can also consider dropping python3.3.

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Nov 23, 2017

Let's make sure to use the python_requires option in setup.py. Ref: pytest-dev/pluggy#106.

@RonnyPfannschmidt
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt commented Nov 24, 2017

please note that tox can drop support for running on said python versions without dropping support for running venvs/tests in them - due to more versatile usage - even in orgs i wonder if a reasonably representative survey can be done

@sigmavirus24
Copy link
Contributor

@sigmavirus24 sigmavirus24 commented Nov 26, 2017

Frankly, if companies/organizations are so stuck on Python 2.6 that they can't get to Python 2.7 they're probably also paying some company (e.g., RedHat) truck-sized payments to support their long-dead version of Python. I don't think, in that case, the community should be doing this maintenance work for free. And distributors with models similar to RedHat will do backports for customers without the community taking on this burden. I'd be happier to see tox make a clean break with insecure versions of Python that aren't supported by the community.

@RonnyPfannschmidt
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt commented Nov 26, 2017

@sigmavirus24 i'm all for dropping support for running on python2.6 - but i wonder how expensive it is to keep running of python 2.6 either in core or in a plugin

@sigmavirus24
Copy link
Contributor

@sigmavirus24 sigmavirus24 commented Nov 26, 2017

You mean running virtualenv -p python2.6? That's probably not expensive for tox developers but that adds costs to virtualenv deprecating support for 2.6 and let's be real, people testing on 2.6 are already pinning setuptools, pip, wheel and lots of other projects to keep their environment working. They should already be pinning known working versions of everything else, in which case, why do you need to support that case for running tests against py26? Eventually that will have added cost. I'm just proposing you avoid that ever happening 😄

@RonnyPfannschmidt
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt commented Nov 26, 2017

@sigmavirus24 true, good point, thanks :)

@The-Compiler
Copy link
Member

@The-Compiler The-Compiler commented Nov 29, 2017

FWIW the Travis jobs for 2.6 and 3.3 started failing because of pytest dropping support for those.

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Nov 29, 2017

yeah, most new PRs we get fail on CI. I was thinking that given this we might as well drop support ourselves, and remove from CI. I'll go ahead with this.

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Nov 29, 2017

Playing devil's advocate, it should be possible to run pytest in 2.6/3.3 if you use pytest-3.2.*.

Having said that, I still think dropping support altogether makes more sense.

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Nov 29, 2017

Python 2.6 reached its EOL in 2013, four years later I think it's about time we drop support for it.

@sigmavirus24
Copy link
Contributor

@sigmavirus24 sigmavirus24 commented Nov 30, 2017

@nicoddemus No one really needs a devil's advocate. It's not really constructive in most conversations. And in this conversation, it's equivalent to advocating for team burnout.

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Nov 30, 2017

No one really needs a devil's advocate. It's not really constructive in most conversations. And in this conversation, it's equivalent to advocating for team burnout.

I certainly didn't mean that, only wanted to mention that pytest-3.2 still works in 2.6/3.3. I apologize if it came across that way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants