Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License #14

Closed
tilmanginzel opened this issue Jan 19, 2019 · 8 comments
Closed

License #14

tilmanginzel opened this issue Jan 19, 2019 · 8 comments

Comments

@tilmanginzel
Copy link

Hi @toy,

thanks for continuing the work of Frederik. :) I would like to use the compiled binary in my Alfred 3 workflow and was wondering if you'd have any problems with that.

Do you mind adding a license to this repository so that others and me can be sure that we are allowed to use and distribute the binary with our software (with attribution to this repository)?

Thanks and best regards
Tilman :)

@toy
Copy link
Owner

toy commented Jan 20, 2019

Hi Tilman,

First reaction: Oh no, license question…

Normally I use MIT license for my projects, caring only about attribution and have nothing against integration of compiled binary. This project lacks a license as I'm not sure how to handle license of a public domain fork and you are the first to ask about it ;) Stackexchange seems to suggest to contact Frederik, so I'll try.

@triplef
Copy link

triplef commented Jan 21, 2019

Hi guys, I’m the original author of blueutil. Great to see my little tool being further developed here!

@toy had emailed me about this license change. I am totally fine with changing the license of this fork to MIT. 👍

@tilmanginzel
Copy link
Author

tilmanginzel commented Jan 21, 2019

First reaction: Oh no, license question…

Yeah, I am sorry I had to be the one asking, but you can see it as a good sign. :)

@toy had emailed me about this license change. I am totally fine with changing the license of this fork to MIT. 👍

Hi Frederik, that's great! I will then add a compiled binary to my project and give proper attribution back to you guys. 👍

@toy
Copy link
Owner

toy commented Jan 21, 2019

@triplef Please have a look at #15 and tell if you want anything to be changed

@triplef
Copy link

triplef commented Jan 22, 2019

@toy looks good, thanks! 👍

@toy toy closed this as completed in ad787d8 Jan 22, 2019
@toy
Copy link
Owner

toy commented Jan 22, 2019

Any strong opinion on bumping patch, minor or major version?

@toy toy reopened this Jan 22, 2019
@tilmanginzel
Copy link
Author

Good question. According to semver it could be seen as a patch, because it's a backwards-compatible change. Some prefer a major version for license changes though (or even a new project, but this would be a bit excessive...).

IMO you have one of the following options:

  • If you think that the license change from none/public domain to MIT might have any negative or breaking impact on current users, be "safe" by using a major version change
  • If you think the license change has no negative or breaking impact at all, just use minor or patch

@toy
Copy link
Owner

toy commented Jan 25, 2019

I came to similar conclusion. I feel that change of license doesn't introduce changes requiring major version increase, so I'll go with minor version increase (patch would be not visible enough).

@toy toy closed this as completed Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants