Optimize from raw image data, not a file

[ippa]

First, thanks for a great lib!

Sometimes in scripts, I already have the imagedata, maybe I've cut up thumbnails for a bigger image or whatever.

It would be nice to be able to optimize that imagedata Without having to first save it to a file so image_optim can read it.

Maybe a new method to not break the current API:
image_optim.optimize_image_data( image_data )

[toy]

You are welcome!

Processing of images as data is already there. You've guessed method name optimize_image_data correctly, also there is optimize_images_data. I just forgot to mention it in readme … already fixed.

[ippa]

oh, heh, funny :). Now I've replaced:

io = IO.popen("/usr/bin/jpegtran -optimize /proc/self/fd/0", "r+").binmode
io.syswrite thumbnail.to_blob
io.flush
io.close_write
optimized_thumbnail = io.read
io.close_read

With:
optimized_thumbnail = @image_optim.optimize_image_data(thumbnail.to_blob)

When I'm saving with active record 4.0.2 the script that just worked suddenly crashes with "Error: invalid byte sequence in UTF-8" .. is there any gotcha in what format optimize_image_data() returns the optimized data?

[ippa]

Hm, ok. The IO.popen-hack returned ASCII-8BIT and optimized_image_data returns UTF-8. I'll have to dig further on my side why it crashes my database save, not a image_optim problem. Thanks again!

[toy]

In reality optimize_image_data should return binary data. I'll put it into master after testing.

[toy]

v0.10.1 out

[ippa]

Things are moving fast, I like it :). Just got bitten by another thing ...optimize_image_data seems to return nil if no optimization is done?

Maybe that's the desired behavior? I was just expecting it to return imagedata as optimized as possible (sometimes that means the original image).

[toy]

nil is returned to indicate failure. Otherwise you would have to compare result with original to determine success. optimize_image and optimize_image! also return nil on failure. If you don't care if optimization was successful or not just use image_optim.optimize_image_data(data) || data.