Copy url utils from cybozu-http-clj #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitouena
commented
Oct 30, 2019
| (not (str/blank? (extract-base-url url)))) | ||
|
|
||
| (def ^:private re-app-url | ||
| (re-pattern (str re-base-url* "/k/(\\d+)"))) |
There was a problem hiding this comment.
JS doesn't have ++. Originally possesive quantifier ++ was used but + seems to be ok here.
saitouena
force-pushed
the
copy-url-utils-from-cybozu-http-clj
branch
2 times, most recently
from
42f7f43
to
b2aef79
Compare
saitouena
force-pushed
the
copy-url-utils-from-cybozu-http-clj
branch
from
b2aef79
to
9b7ddbd
Compare
makinoshi
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy and pasted some utils from https://github.com/ayato-p/cybozu-http-clj/blob/master/src/cybozu_http/kintone/url.clj (MIT License)