Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default total count true for get-records-by-query #6

Merged
merged 4 commits into from Oct 31, 2019

Conversation

saitouena
Copy link
Contributor

Rationale

before:

(-> (<!! (record/get-records-by-query conn app {:total-count true}))
     :res
     :totalCount)

It requires kebab-case keyword but returns with camelCase keyword. This is confusing.
after:

(-> (<!! (record/get-records-by-query conn app))
     :res
     :totalCount)

This situation only happens in get-records-by-query for now. To set totalCount: true makes it easy.

Note for kebab-case and camelCase is also added.

@saitouena saitouena merged commit 5b6e46e into master Oct 31, 2019
@saitouena saitouena deleted the default-total-count-true branch October 31, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants