Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite existing ID parameters in default transformation #15

Closed
nuest opened this issue Nov 4, 2016 · 2 comments
Closed

Don't overwrite existing ID parameters in default transformation #15

nuest opened this issue Nov 4, 2016 · 2 comments

Comments

@nuest
Copy link
Contributor

nuest commented Nov 4, 2016

The documents in my MongoDB schema have an id attribute, which is overwritten by the default transform(..) function. I see different options to make this more flexible (e.g. with an environment variable or by re-introducing settings), but the simplest solution seems to be to only make the "id shift" if the ID parameter does not exist, log a warning, and let the user handle the copying of the id in their transform function.

I am adding changes to that effect to #14

@nuest
Copy link
Contributor Author

nuest commented Nov 8, 2016

@toystars Are you planning to make a release soon?

@toystars
Copy link
Owner

toystars commented Nov 8, 2016

@nuest Once there are substantial additions, I'll make a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants