Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to ../node_modules/ #3

Closed
cdauth opened this issue Mar 10, 2016 · 0 comments
Closed

Remove reference to ../node_modules/ #3

cdauth opened this issue Mar 10, 2016 · 0 comments

Comments

@cdauth
Copy link

cdauth commented Mar 10, 2016

In some places (as far as I can tell in src/codeblock.component.scss and src/codeblock.component.ts), files in the directory ../node_modules/ are referenced.

The reference in the .scss file is resolved during the build process of ng2-prism and thus does not appear in the npm package, but the reference in the .ts file remains in the resulting .d.ts file.

When depending on ng2-prism in a project, the file structure will look like this (using NPM v3):

node_modules
|-- ng2-prism
|   |-- bundle
|   |   |-- codeblock.component.d.ts
|-- angular2
|   |-- typings
|   |   |-- browser.d.ts

The reference to ../node_modules/angular2/typings/browser.d.ts in codeblock.component.d.ts can thus not be resolved, as the node_modules folder is higher in the hierarchy. This results in a tsc compilation error.

I don't know what's the best way to resolve this issue, but I would assume the triple slash reference to angular2/typings/browser.d.ts is not needed and can be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants