Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8.x support #38

Closed
adamwaclawczyk opened this issue Nov 7, 2023 · 1 comment
Closed

PHP8.x support #38

adamwaclawczyk opened this issue Nov 7, 2023 · 1 comment

Comments

@adamwaclawczyk
Copy link

With PHP8, this module throws an error during code compilation

PHP Fatal error:  Declaration of tpaycom\magento2basic\Controller\tpay\Notification::createCsrfValidationException(Magento\Framework\App\RequestInterface $request) must be compatible with Magento\Framework\App\CsrfAwareActionInterface::createCsrfValidationException(Magento\Framework\App\RequestInterface $request): ?Magento\Framework\App\Request\InvalidRequestException in /builds/magento2/hyva-demo-package/vendor/tpaycom/magento2basic/Controller/tpay/Notification.php on line 109

Fixed in PR #37
@kwojc
Copy link
Contributor

kwojc commented Mar 15, 2024

Fixed in 2.0.0

@kwojc kwojc closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwojc @adamwaclawczyk