Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.TypeLoadException : Method 'get_LineCount' in type 'lexer@289' from assembly 'FSharp.CodeFormat #301

Closed
ovatsus opened this issue Apr 19, 2015 · 12 comments

Comments

@ovatsus
Copy link

ovatsus commented Apr 19, 2015

I did a paket update:

image

And now I get this when running the documentation tests:

image

Is there something I need to fix?

@forki
Copy link
Member

forki commented Apr 19, 2015

I saw this before and I thought @tomaspetricek said that we we need to pin a dependency (IIRC the powetools). But I would like to see the pin happen directly in FSF so that it solves it for everyone.

@matthid
Copy link
Member

matthid commented Apr 19, 2015

Lock FSharpVSPowerTool to 1.7.0, see #294 #277.
I think this is already fixed in master, there is just no NuGet release with the fix (jet).

@forki
Copy link
Member

forki commented Apr 19, 2015

Ok what is missing? Why can't we just release this fixed version on nuget?

@ovatsus
Copy link
Author

ovatsus commented Apr 19, 2015

Humm, I'm not even referencing FSharpVSPowerTool directly, should I?

@matthid
Copy link
Member

matthid commented Apr 19, 2015

@ovatsus Either that or stay on an older FSharp.Formatting version

@forki: We need to ask @tpetricek, but I would assume he wants to look over the open PRs or do some further testing or just has not found the time to do it :).

It's a bit sad that the next release will probably break everyone who locked the powertools version again. Does paket throw an error if FSharp.Formatting is locked to 1.8 and the dependencies file is locked to 1.7 or will it simply use 1.7?

@forki
Copy link
Member

forki commented Apr 19, 2015

No normally you shouldn't. That's why I'd like to see a new fsf package. But in order to get your current issue fixed: Yes you need to add the powetools to the dependencies file and pin the version.

Or you revert the update and wait a bit.

@forki
Copy link
Member

forki commented Apr 19, 2015

@matthid: it will not throw. It will just not update since it tries to unify all requirements. That means it will install the latest fsf that's compatible to your pinned powertools version. That means it might never update again - until you remove the pin.

@ovatsus
Copy link
Author

ovatsus commented Apr 19, 2015

BTW, that paragraph should be on Paket docs

@ovatsus
Copy link
Author

ovatsus commented Apr 19, 2015

(and the output of paket should maybe log when it doesn't get the latest of some package because of a pin of a dependent package)

@forki
Copy link
Member

forki commented Apr 19, 2015

Good idea. I created two issues

@ovatsus
Copy link
Author

ovatsus commented Apr 19, 2015

Great, thanks!

@ovatsus ovatsus closed this as completed Apr 19, 2015
@tpetricek
Copy link
Member

Sorry everyone for the delay…

@tpetricek not only had to do some testing, but also had to do one talk in Prague, another at F# eXchange, move to Cambridge, do F# trainings & various other stuff. Oh, and he also didn’t have internet at home…

In any case, new version of F# Formatting with all the fixes should now be released!

From: matthid [mailto:notifications@github.com]
Sent: Sunday, April 19, 2015 12:56 PM
To: tpetricek/FSharp.Formatting
Cc: Tomas Petricek
Subject: Re: [FSharp.Formatting] System.TypeLoadException : Method 'get_LineCount' in type 'lexer@289' from assembly 'FSharp.CodeFormat (#301)

@ovatsus https://github.com/ovatsus Either that or stay on an older FSharp.Formatting version

@forki https://github.com/forki : We need to ask @tpetricek https://github.com/tpetricek , but I would assume he wants to look over the open PRs or do some further testing or just has not found the time to do it :).

It's a bit sad that the next release will probably break everyone who locked the powertools version again. Does paket throw an error if FSharp.Formatting is locked to 1.8 and the dependencies file is locked to 1.7 or will it simply use 1.7?


Reply to this email directly or view it on GitHub #301 (comment) . https://github.com/notifications/beacon/AAdoJZRaJdHXQCGcL6WxiLKZaJzmiSeMks5oA49ggaJpZM4EDst3.gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants