New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.TypeLoadException : Method 'get_LineCount' in type 'lexer@289' from assembly 'FSharp.CodeFormat #301
Comments
I saw this before and I thought @tomaspetricek said that we we need to pin a dependency (IIRC the powetools). But I would like to see the pin happen directly in FSF so that it solves it for everyone. |
Ok what is missing? Why can't we just release this fixed version on nuget? |
Humm, I'm not even referencing FSharpVSPowerTool directly, should I? |
@ovatsus Either that or stay on an older FSharp.Formatting version @forki: We need to ask @tpetricek, but I would assume he wants to look over the open PRs or do some further testing or just has not found the time to do it :). It's a bit sad that the next release will probably break everyone who locked the powertools version again. Does paket throw an error if FSharp.Formatting is locked to 1.8 and the dependencies file is locked to 1.7 or will it simply use 1.7? |
No normally you shouldn't. That's why I'd like to see a new fsf package. But in order to get your current issue fixed: Yes you need to add the powetools to the dependencies file and pin the version. Or you revert the update and wait a bit. |
@matthid: it will not throw. It will just not update since it tries to unify all requirements. That means it will install the latest fsf that's compatible to your pinned powertools version. That means it might never update again - until you remove the pin. |
BTW, that paragraph should be on Paket docs |
(and the output of paket should maybe log when it doesn't get the latest of some package because of a pin of a dependent package) |
Good idea. I created two issues |
Great, thanks! |
Sorry everyone for the delay… @tpetricek not only had to do some testing, but also had to do one talk in Prague, another at F# eXchange, move to Cambridge, do F# trainings & various other stuff. Oh, and he also didn’t have internet at home… In any case, new version of F# Formatting with all the fixes should now be released! From: matthid [mailto:notifications@github.com] @ovatsus https://github.com/ovatsus Either that or stay on an older FSharp.Formatting version @forki https://github.com/forki : We need to ask @tpetricek https://github.com/tpetricek , but I would assume he wants to look over the open PRs or do some further testing or just has not found the time to do it :). It's a bit sad that the next release will probably break everyone who locked the powertools version again. Does paket throw an error if FSharp.Formatting is locked to 1.8 and the dependencies file is locked to 1.7 or will it simply use 1.7? — |
I did a paket update:
And now I get this when running the documentation tests:
Is there something I need to fix?
The text was updated successfully, but these errors were encountered: