Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render static private members #59

Closed
forki opened this issue Oct 30, 2013 · 5 comments
Closed

Don't render static private members #59

forki opened this issue Oct 30, 2013 · 5 comments

Comments

@forki
Copy link
Member

forki commented Oct 30, 2013

Hi,

image

renders:

image

It's private and therefor I think it should be omitted.

Cheers,
Steffen

@tpetricek
Copy link
Member

I included fix from @soloman817 (in the PowerPack code) that filtered out some private members, but I'm not sure if that fixed this issue too. Can you please check?

@soloman817
Copy link
Contributor

@forki @tpetricek I can see from your screenshot that you might not use the newest one, because in newest source, the name shouldn't include the type name, it would be GetParams, not Shell.GetParams. So I suggest:

  1. use the newest one of fsformatting.
  2. verify the output name, to see if it is newest one.
  3. if the problem still exists, please clone https://github.com/soloman817/FSharpPowerPack and then build only the FSharpPowerPack.Metadata, and then copy the built dll to override the one that shipped with fsformatting.

@tpetricek
Copy link
Member

BTW: @soloman817 I included your version of FSharpPowerPack in the src directory of FSharp.Formatting, so that we can maintain this project here (I doubt anyone else will need it). I'll include it in a new NuGet package (building now)

@soloman817
Copy link
Contributor

@tpetricek yes, I just pushed your repo to my repo, and checked the commits, and see that you included the metadata. This is good.

@matthid
Copy link
Member

matthid commented Sep 20, 2015

I'm pretty sure we now properly filter out private stuff when publicOnly is set to true. Please comment if this is still not working.

@matthid matthid closed this as completed Sep 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants